feat: menu for hidden nav items #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbrusegard
requested changes
Nov 21, 2024
| @@ -18,21 +21,39 @@ function Header() { | |||
| news: t('news'), | |||
| events: t('events'), | |||
| about: t('about'), | |||
| storage: t('storage'), | |||
| shiftSchedule: t('shiftSchedule'), | |||
| hackerspaceHome: t('hackerspaceHome'), | |||
| close: useTranslations('ui')('close'), | |||
There was a problem hiding this comment.
This is unrelated to this issue but the 'ui' namespaces is available in all client components so when we use from it we dont have to pass it as a prop we can use useTranslations('ui') within the client component
MoaKK
reviewed
Nov 21, 2024
MoaKK
reviewed
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added menu to access pages that aren't in the main navigation component in the header. Also added button to go to matrix and moved internal navigation links into a separate component.
Closes #74